Skip to content

Upgrade Prometheus to latest master and reflect changes#2748

Merged
bwplotka merged 2 commits intothanos-io:masterfrom
kakkoyun:upgrade_prometheus_master
Jun 11, 2020
Merged

Upgrade Prometheus to latest master and reflect changes#2748
bwplotka merged 2 commits intothanos-io:masterfrom
kakkoyun:upgrade_prometheus_master

Conversation

@kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Jun 10, 2020

Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com

  • I added CHANGELOG entry for this change.

Changes

Verification

  • make build
  • make test-local

@kakkoyun kakkoyun force-pushed the upgrade_prometheus_master branch from 1bb2801 to c5d4703 Compare June 10, 2020 08:57
@kakkoyun kakkoyun requested a review from pracucci June 10, 2020 08:58
@kakkoyun kakkoyun marked this pull request as ready for review June 10, 2020 08:58
@kakkoyun kakkoyun requested a review from bwplotka June 10, 2020 08:58
kakkoyun added 2 commits June 10, 2020 16:50
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@kakkoyun kakkoyun force-pushed the upgrade_prometheus_master branch from c5d4703 to f36f7f9 Compare June 10, 2020 14:50
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

This also fixed the correctness bug I believe @pracucci (:

@bwplotka bwplotka merged commit 48ee1f8 into thanos-io:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants