query: Fix external prefix and add an e2e test for it#2800
query: Fix external prefix and add an e2e test for it#2800GiedriusS merged 12 commits intothanos-io:masterfrom
Conversation
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
a2f811e to
280299e
Compare
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
280299e to
f5bff42
Compare
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
|
Now that we are more in line with what Prometheus does, the following guides also works for Thanos.
The only difference is that, instead of using the Prometheus flag |
GiedriusS
left a comment
There was a problem hiding this comment.
Awesome work! Just a few comments on how to improve this 🎉
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
87f9ea1 to
eb4dff8
Compare
|
Seems like Netlify is having some problems. |
GiedriusS
left a comment
There was a problem hiding this comment.
The code looks good! I think we should another iteration on the documentation and then we can merge this :P Mostly grammar nits + renamed Thanos querier to Thanos Query to be consistent.
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
GiedriusS
left a comment
There was a problem hiding this comment.
LGTM. Even tested with a reverse proxy with the example configuration in the documentation and it works with these changes whereas with the master version you get redirected to http://localhost/thanos/thanos/graph with identical configuration.
I'll give @squat and others time to review these changes if they want to before merging this. Awesome stuff!
squat
left a comment
There was a problem hiding this comment.
Looks great overall, Prem! Great work and thanks for the docs! Just some small nits
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
|
Oops, fixing up the CHANGELOG in #2833. |
Changes
--web.external-prefixusing a simple reverse proxy--web.external-prefixand--web.route-prefixin a single scenario, i.e. when both are set simultaneously.Changes in
externalPrefixandroutePrefixhandling--web.route-prefixdefaults to--web.external-prefix. This behavior allows a user to usethanoswith and without a reverse proxy if--web.external-prefixis set, and it is in line with what Prometheus does.--web.external-prefixTurns out,--web.external-prefixis still broken, and as expected, these tests would fail unless we fix it.It should work now.
This PR changes how
--web.external-prefixworks, so it can make the UI inaccessible to some users who were relying on some workarounds or hacks before (like setting--web.external-prefix=".").Verification
Ran
GOTEST_OPTS="-run TestQuery" make test-e2elocally to test all e2e tests related to Query component.