Skip to content

Query: always return a string in the lastError field #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwplotka merged 4 commits into from
Jun 30, 2020
Merged

Query: always return a string in the lastError field #2809

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac6bf41
Query: always return a string in the `lastError` field
GiedriusS Jun 25, 2020
3d55e25
CHANGELOG: add PR number + remove whitespace
GiedriusS Jun 25, 2020
3c3416e
query/storeset: fix a subtle bug
GiedriusS Jun 25, 2020
1ac9338
Make changes according to Bartek's suggestions
GiedriusS Jun 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CHANGELOG: add PR number + remove whitespace 
Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
  • Loading branch information
@GiedriusS
GiedriusS committed Jun 25, 2020
commit 3d55e25410e3e921b11b7ee200b7f8111c494d4a
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ We use *breaking* word for marking changes that are not backward compatible (rel
- [#2728](https://github.com/thanos-io/thanos/pull/2728) Query: Fixed panics when using larger number of replica labels with short series label sets.
- [#2787](https://github.com/thanos-io/thanos/pull/2787) Update Prometheus mod to pull in prometheus/prometheus#7414.
- [#2807](https://github.com/thanos-io/thanos/pull/2807) Store: decreased memory allocations while querying block's index.
- []() Query: `/api/v1/stores` now guarantees to return a string in the `lastError` field
- [#2809](https://github.com/thanos-io/thanos/pull/2809) Query: `/api/v1/stores` now guarantees to return a string in the `lastError` field

### Changed

Expand Down