Skip to content

ci: Manually download promu in crossbuild stage#2828

Merged
bwplotka merged 2 commits intothanos-io:release-0.14from
kakkoyun:circleci_corssbuild
Jul 2, 2020
Merged

ci: Manually download promu in crossbuild stage#2828
bwplotka merged 2 commits intothanos-io:release-0.14from
kakkoyun:circleci_corssbuild

Conversation

@kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Jul 1, 2020

@kakkoyun
Manually download promu in crossbuild stage
d7f14ef 
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@kakkoyun kakkoyun requested a review from bwplotka July 1, 2020 14:58
bwplotka
bwplotka reviewed Jul 1, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just one comment.

Let's merge this to release branch for now then you can run

tag=$(< VERSION) && git tag --delete v${tag} &&  git push --delete origin v${tag}
tag=$(< VERSION) && echo ${tag} && git tag -s "v${tag}" -m "v${tag}" && git push origin "v${tag}"

.circleci/config.yml
steps:
- checkout
- run: curl -L "https://github.com/prometheus/promu/releases/download/v${PROMU_VERSION}/promu-${PROMU_VERSION}.$(go env GOOS)-$(go env GOARCH).tar.gz" | tar --strip-components=1 -xzf - -C ${GOBIN}
- run: source .bingo/variables.env
Copy link
Member

@bwplotka bwplotka Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't want to source those things BEFORE running curl? 🤔

@kakkoyun kakkoyun changed the base branch from master to release-0.14 July 2, 2020 06:08
@kakkoyun
Make sure all directories created in the path
a1749b6 
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@kakkoyun kakkoyun force-pushed the circleci_corssbuild branch from 487ec70 to a1749b6 Compare July 2, 2020 06:28
kakkoyun
kakkoyun commented Jul 2, 2020
View reviewed changes
Makefile
.PHONY: crossbuild
crossbuild: ## Builds all binaries for all platforms.
crossbuild: deps $(PROMU)
crossbuild: | $(PROMU)
Copy link
Member Author

@kakkoyun kakkoyun Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipe makes sure that dependency doesn't run if the file already exists.
https://www.gnu.org/software/make/manual/html_node/Prerequisite-Types.html

Copy link
Member

@bwplotka bwplotka Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think even without pipe that is happening. I guess it does not check mod file?

Copy link
Member Author

@kakkoyun kakkoyun Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested locally somehow, it still tries to execute bingo install task. Just to be sure.

@kakkoyun kakkoyun requested a review from bwplotka July 2, 2020 06:30
bwplotka
bwplotka approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it out!

@bwplotka bwplotka merged commit f5781e7 into thanos-io:release-0.14 Jul 2, 2020
@kakkoyun kakkoyun deleted the circleci_corssbuild branch July 2, 2020 09:55
kakkoyun added a commit that referenced this pull request Jul 2, 2020
@kakkoyun
ci: Manually download promu in crossbuild stage (#2828)
a8e4e31 
* Manually download promu in crossbuild stage

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Make sure all directories created in the path

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun added a commit that referenced this pull request Jul 2, 2020
@kakkoyun
ci: Manually download promu in crossbuild stage (#2828)
3c88816 
* Manually download promu in crossbuild stage

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Make sure all directories created in the path

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun added a commit to kakkoyun/thanos that referenced this pull request Jul 2, 2020
@kakkoyun
ci: Manually download promu in crossbuild stage (thanos-io#2828)
ce243cb 
* Manually download promu in crossbuild stage

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Make sure all directories created in the path

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun added a commit that referenced this pull request Jul 2, 2020
@kakkoyun
ci: Manually download promu in crossbuild stage (#2828)
00e3c32 
* Manually download promu in crossbuild stage

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Make sure all directories created in the path

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
paulfantom added a commit to paulfantom/thanos that referenced this pull request Jul 9, 2020
@paulfantom
Merge remote-tracking branch 'upstream/release-0.14' into 0.14
9c227bc 
* upstream/release-0.14: (46 commits)
  Cut release v0.14.0-rc.1 (thanos-io#2853)
  Query: correctly marshal errors to JSON and ignore if nil (thanos-io#2848)
  ci: Manually download promu in crossbuild stage (thanos-io#2828)
  Cut release v0.14.0-rc.0 (thanos-io#2826)
  Soft cut changelog on master to indicate v0.14.0 being in progress (thanos-io#2824)
  Update ThanosReceiveNoUpload to select sum == 0 (thanos-io#2819)
  receive: Added more observability, fixed leaktest, to actually check leaks ): (thanos-io#2817)
  Query: always return a string in the `lastError` field (thanos-io#2809)
  Added missing CHANGELOG entry for PR 2613 (thanos-io#2820)
  receive: Fixed small options race; Removed unused StartTime feature. (thanos-io#2816)
  go.mod: Bump Prometheus to current latest (thanos-io#2814)
  Implement CLI Flags page in React UI (thanos-io#2796)
  Improve ThanosReceiveNoUpload to only alert on current instances
  store: Preallocate output buffer when encoding postings. (thanos-io#2812)
  compact: introduce flag --block-viewer.global.sync-block-interval (thanos-io#2752)
  docs: compact: add blurb about how retention policy works (thanos-io#2808)
  Reduced memory allocations in readIndexRange() (thanos-io#2807)
  ui: Add Stores page to React UI (thanos-io#2754)
  Added Kemal to Maintainer Role; Kemal is volounteering to be next release shephard (thanos-io#2804)
  proposal: Add scalable rule storage proposal (thanos-io#2661)
  ...
kakkoyun added a commit to kakkoyun/thanos that referenced this pull request Jul 10, 2020
@kakkoyun
ci: Manually download promu in crossbuild stage (thanos-io#2828)
43fa199 
* Manually download promu in crossbuild stage

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Make sure all directories created in the path

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
bwplotka pushed a commit that referenced this pull request Jul 13, 2020
@kakkoyun
Merge v0.14.0 to master (#2878)
4f876c4 
* Cut release v0.14.0-rc.0 (#2826)

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* ci: Manually download promu in crossbuild stage (#2828)

* Manually download promu in crossbuild stage

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Make sure all directories created in the path

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Cut release v0.14.0-rc.1 (#2853)

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Cut release v0.14.0 (#2877)

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kakkoyun @bwplotka