Query: Fix rendered JSON state value for rules and alerts should be in lowercase#2834
Merged
brancz merged 1 commit intothanos-io:masterfrom Jul 3, 2020
Merged
Conversation
4013d66 to
024cfed
Compare
024cfed to
70a79ff
Compare
Member
|
There appear to be a couple more occurrences in tests that need to be fixed. Otherwise lgtm |
Currently, alert state is rendered as upper case. In Prometheus it is lower case. This fixes it. Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
70a79ff to
dfb820f
Compare
Contributor
Author
|
@brancz all green, PTAL :-) |
2 tasks
paulfantom
pushed a commit
to paulfantom/thanos
that referenced
this pull request
Jul 8, 2020
Currently, alert state is rendered as upper case. In Prometheus it is lower case. This fixes it. Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
paulfantom
pushed a commit
to paulfantom/thanos
that referenced
this pull request
Jul 9, 2020
Currently, alert state is rendered as upper case. In Prometheus it is lower case. This fixes it. Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, alert state is rendered as upper case.
In Prometheus it is lower case.
This fixes it.
Signed-off-by: Sergiusz Urbaniak sergiusz.urbaniak@gmail.com
Fixes #2830
Changes
Verification