Skip to content

receive,ruler: Upgraded TSDB and used ChunkIterator in Series TSDB Store.#2876

Merged
bwplotka merged 1 commit intomasterfrom
chunk-iter-receive
Aug 10, 2020
Merged

receive,ruler: Upgraded TSDB and used ChunkIterator in Series TSDB Store.#2876
bwplotka merged 1 commit intomasterfrom
chunk-iter-receive

Conversation

@bwplotka
Copy link
Member

@bwplotka bwplotka commented Jul 10, 2020

Finally some first tests of chunk iterator ❤️

Benchmarks to come.

Depends on: prometheus/prometheus#7069

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

@bwplotka bwplotka mentioned this pull request Jul 10, 2020
Merged
@bwplotka bwplotka force-pushed the chunk-iter-receive branch from 1ea3f23 to 1103945 Compare July 10, 2020 11:37
@bwplotka bwplotka force-pushed the chunk-iter-receive branch from 1103945 to 8fc06c7 Compare July 27, 2020 12:01
@bwplotka bwplotka marked this pull request as ready for review July 27, 2020 12:02
@bwplotka
Copy link
Member Author

bwplotka commented Jul 27, 2020

Given stable and well looking prometheus/prometheus#7069 I think this is ready to go and even merged. Building now docker image for staging.

@bwplotka bwplotka changed the title Upgraded TSDB and used ChunkIterator in Series TSDB Store. receive,ruler: Upgraded TSDB and used ChunkIterator in Series TSDB Store. Jul 27, 2020
@bwplotka bwplotka force-pushed the chunk-iter-receive branch from 8fc06c7 to 9e8396c Compare July 27, 2020 12:26
yeya24
yeya24 reviewed Jul 27, 2020
View reviewed changes
@bwplotka bwplotka force-pushed the chunk-iter-receive branch from 9e8396c to 098fb25 Compare July 27, 2020 13:34
@bwplotka
Copy link
Member Author

bwplotka commented Jul 27, 2020

v0.15.0-pre-rc-chunk-iter.0 was build from this.

@bwplotka bwplotka force-pushed the chunk-iter-receive branch from 098fb25 to 048935f Compare July 27, 2020 19:50
@bwplotka bwplotka mentioned this pull request Jul 27, 2020
Merged
@bwplotka bwplotka force-pushed the chunk-iter-receive branch 3 times, most recently from 189c9d3 to bc00c59 Compare July 27, 2020 20:41
@bwplotka
Copy link
Member Author

bwplotka commented Jul 28, 2020

There is still one bug here: compact-working: level=error name=compact-working ts=2020-07-28T08:57:18.033854652Z caller=compact.go:364 msg="critical error detected; halting" err="compaction: group 0@6431778317510635118: invalid result block /shared/data/compact/working/compact/0@6431778317510635118/01EEAA7VD674ABSV1GND6VQ7A3: 1/4 series have an average of 1.000 out-of-order chunks: 0.000 of these are exact duplicates (in terms of data and time range)" store-gw-1: level=info name=store-gw-1 ts=2020-07-28T08:57:20.789789976Z caller=fetcher.go:453 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=39.407118ms cached=27 returned=21 partial=7

@bwplotka bwplotka force-pushed the chunk-iter-receive branch from bc00c59 to 8dda89a Compare July 31, 2020 12:18
@bwplotka
Copy link
Member Author

bwplotka commented Jul 31, 2020

All should be green now! 💪

Please PTAL @GiedriusS @kakkoyun @brancz when you have time.

@bwplotka
Copy link
Member Author

bwplotka commented Jul 31, 2020

v0.15.0-pre-rc-chunk-iter.1 was build for it.

@bwplotka bwplotka force-pushed the chunk-iter-receive branch 2 times, most recently from 48e7ada to 73f8907 Compare August 3, 2020 10:44
kakkoyun
kakkoyun reviewed Aug 3, 2020
View reviewed changes
@bwplotka bwplotka force-pushed the chunk-iter-receive branch 2 times, most recently from 78c1313 to 8249066 Compare August 7, 2020 20:51
@bwplotka
Copy link
Member Author

bwplotka commented Aug 7, 2020

Ready to go! (:

cc @yeya24 could you help with review? (:

@bwplotka bwplotka force-pushed the chunk-iter-receive branch from 8249066 to 8f317a1 Compare August 7, 2020 23:02
yeya24
yeya24 reviewed Aug 7, 2020
View reviewed changes
@bwplotka bwplotka force-pushed the chunk-iter-receive branch from 8f317a1 to 8e2c6a4 Compare August 10, 2020 17:04
@bwplotka
Copy link
Member Author

bwplotka commented Aug 10, 2020

Thanks for review @yeya24 addressed!

yeya24
yeya24 reviewed Aug 10, 2020
View reviewed changes
@bwplotka
receive,ruler: Upgraded TSDB and used ChunkIterator in Series TSDB St…
c08f775 
…ore.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bwplotka bwplotka force-pushed the chunk-iter-receive branch from 8e2c6a4 to c08f775 Compare August 10, 2020 17:11
yeya24
yeya24 approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🥇

@bwplotka bwplotka merged commit 626f248 into master Aug 10, 2020
@bwplotka bwplotka deleted the chunk-iter-receive branch August 10, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun left review comments

@yeya24 yeya24 yeya24 approved these changes

@pracucci pracucci Awaiting requested review from pracucci

@brancz brancz Awaiting requested review from brancz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bwplotka @kakkoyun @yeya24