receive: Overhaul start up sequence#2892
Merged
bwplotka merged 7 commits intothanos-io:masterfrom Jul 23, 2020
Merged
Conversation
Add more logs fo receive Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
squat
reviewed
Jul 14, 2020
squat
reviewed
Jul 14, 2020
bwplotka
reviewed
Jul 14, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Awesome! Generally ok, some comments on details. Upload flag is non trivial, let's be careful - despite it being hidden
squat
reviewed
Jul 14, 2020
squat
approved these changes
Jul 14, 2020
Member
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
Looks good, just some small comments and one thing that may be confusing for users
kakkoyun
force-pushed
the
receive_shutdown_logs
branch
from
bab4e1b to
5d6a04c
Compare
Merge uploader routines Address review issues Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
force-pushed
the
receive_shutdown_logs
branch
from
5d6a04c to
437c7b6
Compare
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
brancz
approved these changes
Jul 15, 2020
bwplotka
reviewed
Jul 15, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM overall, just some nits. The biggest thing is with the timeout, I think we need to improve it before merge.
Thanks!
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
force-pushed
the
receive_shutdown_logs
branch
from
5f8d249 to
d9ced69
Compare
kakkoyun
changed the title
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
bwplotka
approved these changes
Jul 23, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Thank you this will help enourmously with clear messages 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
Changes
Verification
make test-localMINIO_ENABLED=1 REMOTE_WRITE_ENABLED=1 ./scripts/quickstart.sh