compact: fix increment of thanos_compact_downsample_total counter#2895
Merged
squat merged 1 commit intothanos-io:masterfrom Jul 15, 2020
Merged
compact: fix increment of thanos_compact_downsample_total counter#2895squat merged 1 commit intothanos-io:masterfrom
squat merged 1 commit intothanos-io:masterfrom
Conversation
`thanos_compact_downsample_total` metric was not incremented for ResLevel1 Signed-off-by: John Belmonte <john@neggie.net>
squat
approved these changes
Jul 15, 2020
Member
|
Thanks a lot @belm0 :) this is a pretty common mistake and it would be great to have some static analysis to catch these issues |
Contributor
Author
That would be hard, since it's valid to end at WithLabelValues() when initializing known label sets. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thanos_compact_downsample_totalmetric was not incremented for ResLevel1