ui: React: Separate dedupe and partial response checkboxes per panel#2902
Merged
GiedriusS merged 5 commits intothanos-io:masterfrom Jul 28, 2020
Merged
ui: React: Separate dedupe and partial response checkboxes per panel#2902GiedriusS merged 5 commits intothanos-io:masterfrom
GiedriusS merged 5 commits intothanos-io:masterfrom
Conversation
… panel Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
Member
|
Can we have quick screenshot for such changes 🤗 ? |
Member
Author
@bwplotka Done 💯 |
GiedriusS
reviewed
Jul 23, 2020
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
The changes look good! Just that I think that we forgot to update parseOption and toQueryString so that those options would end up in the URL itself. Let's improve them and I think we can merge this
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
onprem
changed the title
onprem
changed the title
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
onprem
force-pushed
the
seperate-chkboxes
branch
from
ae70a50 to
12e517a
Compare
GiedriusS
reviewed
Jul 27, 2020
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
Sorry for being a nuisance but could we change max_source_res to be max_source_resolution so that it would match the old UI? I think there would be some value in being able to copy/paste the params between the UIs. Other than that, I think this is good to go. WDYT?
bwplotka
approved these changes
Jul 27, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Amazing ❤️
(modulo @GiedriusS comment)
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
bwplotka
approved these changes
Jul 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Verification
Tested locally by running unit tests and reviewing network requests.
Screenshots
Before
Deduplication and Partial Response checkboxes were global
Now
Moved these options to per panel
