Add time range parameters to labels API#2964
Merged
bwplotka merged 2 commits intothanos-io:masterfrom Aug 6, 2020
Merged
Conversation
yeya24
force-pushed
the
add-time-params-label-api
branch
from
f5773fe to
bc9005d
Compare
yeya24
changed the title
Contributor
Author
|
This pr is ready for review! |
yeya24
force-pushed
the
add-time-params-label-api
branch
from
bc9005d to
c6661b4
Compare
yeya24
force-pushed
the
add-time-params-label-api
branch
6 times, most recently
from
0da6da5 to
91d8a5c
Compare
bwplotka
approved these changes
Aug 1, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Amazing, good work! 💪 It's perfect really just one comment (:
pkg/api/query/v1.go
Outdated
| if err != nil { | ||
| return nil, nil, &api.ApiError{Typ: api.ErrorBadData, Err: err} | ||
| } | ||
| // Prometheus doesn't check this, do we need to? |
Member
There was a problem hiding this comment.
Sounds useful, no? (:
Please ask comments on PR itself not in comment (: So we can still merge PR if code is ok.
Member
There was a problem hiding this comment.
I think we should and it's probably worth contributing such a check upstream IMHO
| // TODO(bwplotka): Move Thanos components to use strategy instead. Including QueryAPI. | ||
| PartialResponseStrategy partial_response_strategy = 2; | ||
|
|
||
| int64 start = 3; |
Signed-off-by: Ben Ye <yb532204897@gmail.com>
yeya24
force-pushed
the
add-time-params-label-api
branch
from
91d8a5c to
2d2cda6
Compare
Contributor
Author
|
I have addressed the comment. Please take a look again. 😄 |
yeya24
force-pushed
the
add-time-params-label-api
branch
from
2d2cda6 to
acd0a5c
Compare
Signed-off-by: Ben Ye <yb532204897@gmail.com>
yeya24
force-pushed
the
add-time-params-label-api
branch
from
acd0a5c to
9a92e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye yb532204897@gmail.com
Changes
Fixes: #1811
Verification