Skip to content

Query: Better rounding for incoming query timestamps.#2976

Merged
GiedriusS merged 1 commit intothanos-io:masterfrom
johncming:timestamp-rounding
Aug 5, 2020
Merged

Query: Better rounding for incoming query timestamps.#2976
GiedriusS merged 1 commit intothanos-io:masterfrom
johncming:timestamp-rounding

Conversation

@johncming
Copy link
Contributor

@johncming johncming commented Aug 4, 2020

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes: #2971

Use same fix like prometheus/prometheus#4941

Verification

  1. Add a test case in TestParseTime and run it.
  2. Run make via ci.

@johncming johncming marked this pull request as draft August 4, 2020 11:17
@johncming johncming changed the title query: Better rounding for incoming query timestamps. Query: Better rounding for incoming query timestamps. Aug 4, 2020
@johncming johncming force-pushed the timestamp-rounding branch from 405cbb8 to 9265897 Compare August 4, 2020 11:24
Signed-off-by: johncming <johncming@yahoo.com>
@johncming johncming force-pushed the timestamp-rounding branch from 9265897 to 818ce1f Compare August 4, 2020 11:58
@johncming johncming mentioned this pull request Aug 4, 2020
@johncming johncming marked this pull request as ready for review August 5, 2020 03:29
Copy link
Member

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@GiedriusS GiedriusS merged commit 7db0cd6 into thanos-io:master Aug 5, 2020
@bwplotka
Copy link
Member

bwplotka commented Aug 6, 2020

Thank you for so quick pr! 😻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All result timestamps off by 1ms for certain floating-point input timestamps

4 participants