REPLICATOR: Add TimePartitionMetaFilter to thanos replicate.#2979
Merged
bwplotka merged 10 commits intothanos-io:masterfrom Nov 3, 2020
Merged
REPLICATOR: Add TimePartitionMetaFilter to thanos replicate.#2979bwplotka merged 10 commits intothanos-io:masterfrom
bwplotka merged 10 commits intothanos-io:masterfrom
Conversation
OGKevin
force-pushed
the
add-time-filter-to-replicate
branch
2 times, most recently
from
9f52fb1 to
cc16483
Compare
OGKevin
commented
Aug 5, 2020
OGKevin
force-pushed
the
add-time-filter-to-replicate
branch
from
bdc6443 to
87d81a3
Compare
brancz
reviewed
Aug 6, 2020
OGKevin
force-pushed
the
add-time-filter-to-replicate
branch
from
d57faab to
e3c36f0
Compare
bwplotka
requested changes
Aug 6, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Nice, just comments around deletion not being part of replicator
Contributor
Author
|
Im waiting on the depended MR to get merged to continue on this one. As the dependent MR will most likely introduce more merging conflicts. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Contributor
Author
Member
Member
|
@OGKevin In the meanwhile, could you maybe rebase and also sign DCO? |
2 tasks
This will allow time based replication. Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
OGKevin
force-pushed
the
add-time-filter-to-replicate
branch
from
e3c36f0 to
a4d95b8
Compare
Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
OGKevin
force-pushed
the
add-time-filter-to-replicate
branch
2 times, most recently
from
2d98401 to
e5297d7
Compare
Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
OGKevin
force-pushed
the
add-time-filter-to-replicate
branch
from
e5297d7 to
c18d069
Compare
Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
Contributor
Author
|
@bwplotka its ready for 👀! |
bwplotka
reviewed
Nov 2, 2020
| fromBkt, | ||
| "", | ||
| reg, | ||
| []thanosblock.MetadataFilter{thanosblock.NewTimePartitionMetaFilter(*minTime, *maxTime)}, |
Member
There was a problem hiding this comment.
Can we add this only if minTime and maxTime are passed? (:
Contributor
Author
There was a problem hiding this comment.
Wouldn't the behaviour be the same? As the max and min are almost infinite. What is the reason for only passing it if its set to non default value?
Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
kakkoyun
reviewed
Nov 3, 2020
bwplotka
approved these changes
Nov 3, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Amazing! Looks good to me 👍
Thanks!
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
…io#2979) * Add TimePartitionMetaFilter to thanos replicate. This will allow time based replication. Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * Update docs and changelog. Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * Fix lint Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * Add posibility to delete blocks older than max time Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * Fix metric naming. Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * Fix order of arguments for max and min time. Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * Remove deletion of blocks from replicator. Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * Fix import formatting Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * Revert unneeded changes due to replicator no longer deleting blocs Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * Fix typo Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow time based replication.
Its blocked by #2906
Changes
Verification