*: Reuse operation name constants for consistency#2991
Merged
kakkoyun merged 2 commits intothanos-io:masterfrom Aug 6, 2020
Merged
*: Reuse operation name constants for consistency#2991kakkoyun merged 2 commits intothanos-io:masterfrom
kakkoyun merged 2 commits intothanos-io:masterfrom
Conversation
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
force-pushed
the
resuse_constants
branch
from
2daf456 to
e468a1a
Compare
kakkoyun
commented
Aug 6, 2020
| originBucket = "bucket" | ||
|
|
||
| opGet = "get" | ||
| opGetRange = "getrange" |
Member
Author
There was a problem hiding this comment.
This was actually mismatching what we have already for bucket.
Contributor
There was a problem hiding this comment.
Doh! I think we should mention this change in the CHANGELOG
Member
There was a problem hiding this comment.
Any mixin / alert we could change?
pracucci
approved these changes
Aug 6, 2020
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
LGTM! I just left a comment about CHANGELOG.
| originBucket = "bucket" | ||
|
|
||
| opGet = "get" | ||
| opGetRange = "getrange" |
Contributor
There was a problem hiding this comment.
Doh! I think we should mention this change in the CHANGELOG
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
bwplotka
approved these changes
Aug 6, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM Let's merge after we check if we can update any mixin (:
| originBucket = "bucket" | ||
|
|
||
| opGet = "get" | ||
| opGetRange = "getrange" |
Member
There was a problem hiding this comment.
Any mixin / alert we could change?
Member
Author
|
@bwplotka Mixin seems ok. We don't have any usage. So merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
Verification
make test-local