Conversation
kakkoyun
reviewed
Aug 11, 2020
Member
kakkoyun
left a comment
kakkoyun
left a comment
There was a problem hiding this comment.
Changes look good to me.
However, tests fail with unexpected error: replace of obsolete block for deletion 01EFE2XDABF7ENW1Y0KVJG69GC: rename /tmp/large-chunk-test176317323/block/01EFE2XDABF7ENW1Y0KVJG69GC /tmp/large-chunk-test176317323/block/01EFE2XDABF7ENW1Y0KVJG69GC.tmp-for-deletion: no such file or directory
Member
Author
|
Nice! |
Member
Author
|
Found upstream bug: prometheus/prometheus#7777 please PTAL @kakkoyun (: |
Member
Author
|
Ok, fixed upstream let's try now: prometheus/prometheus#7777 |
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Member
Contributor
kakkoyun
approved these changes
Aug 11, 2020
Member
kakkoyun
left a comment
kakkoyun
left a comment
There was a problem hiding this comment.
LGTM. Failing tests are unrelated to these changes.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com
xref: prometheus/prometheus#7772