querier: Add a flag to limit time range for metadata APIs (Labels and Series)#3147
Merged
kakkoyun merged 7 commits intothanos-io:masterfrom Sep 21, 2020
Merged
querier: Add a flag to limit time range for metadata APIs (Labels and Series)#3147kakkoyun merged 7 commits intothanos-io:masterfrom
kakkoyun merged 7 commits intothanos-io:masterfrom
Conversation
kakkoyun
force-pushed
the
limit_label_apis
branch
from
bbf36a1 to
87bd71b
Compare
kakkoyun
force-pushed
the
limit_label_apis
branch
3 times, most recently
from
f84bd95 to
c751c96
Compare
kakkoyun
changed the title
kakkoyun
changed the title
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
force-pushed
the
limit_label_apis
branch
from
8b26236 to
1ebbb5c
Compare
Member
Author
|
friendly ping @bwplotka |
bwplotka
reviewed
Sep 21, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Amazing, thanks! Some suggestion, otherwise LGTM 👍
kakkoyun
changed the title
Implement time ranges for series API Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Member
Author
|
@bwplotka Addressed the raised issues and included |
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
bwplotka
approved these changes
Sep 21, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM, 👍
Thanks! 💪
I think it would be amazing to actually propose changing the default for this being ~1d or something in next release (:
yeya24
approved these changes
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
WIP
Ref #3119
Fixes #1811
Changes
query.metadata.default-time-rangeflag to specify the default look-back duration for retrieving labels through Labels APIs when time range parameters are not specified.Verification
make test-local