*: Handling query logging for code 3xx#3181
Conversation
|
Can you fix the failing tests, this seems due to DCO - https://github.com/thanos-io/thanos/blob/master/CONTRIBUTING.md#pull-request-process |
|
In my opinion, 3XX status codes are expected and a bit verbose so they should go under the |
Signed-off-by: aribalam <arib.alam.iitkgp@gmail.com>
|
@aribalam Can you please also update the changelog? This is a user-facing change. Thank you! |
Signed-off-by: aribalam <arib.alam.iitkgp@gmail.com>
Signed-off-by: aribalam <arib.alam.iitkgp@gmail.com>
aribalam
changed the title
|
As @prmsrswt suggested, the logging was changed to the |
CHANGELOG.md
Outdated
|
|
||
| ### Added | ||
|
|
||
| - [#3181](https://github.com/thanos-io/thanos/pull/3181) Query Frontend: Add debug level logging for responses between 300-399 |
There was a problem hiding this comment.
It is not specific to Query Frontend component. This change is for the logging library and I think all components with an HTTP server are using it. @yashrsharma44 Hi, can you please help confirm this?
There was a problem hiding this comment.
Yeah, it is not a Query Frontend component issue.
@aribalam can you change the component to Logging, because the change affects all the components which use logging.
Signed-off-by: aribalam <arib.alam.iitkgp@gmail.com>
kakkoyun
left a comment
kakkoyun
left a comment
There was a problem hiding this comment.
🥇 Thanks a lot for the contribution.
kakkoyun
changed the title
5 participants
Changes
Fixes #3174
Handled logging for return codes 3xx at Info level. Initially the responses were logged as error
@yashrsharma44 @yeya24 Please let me know if it should be handled in any other way.
Verification