Compact: Fix web.prefix-header to use &wc.prefixHeaderName#3184
Merged
kakkoyun merged 2 commits intothanos-io:masterfrom Sep 18, 2020
daksh-sagar:external-prefix
Merged
Compact: Fix web.prefix-header to use &wc.prefixHeaderName#3184kakkoyun merged 2 commits intothanos-io:masterfrom daksh-sagar:external-prefix
kakkoyun merged 2 commits intothanos-io:masterfrom
daksh-sagar:external-prefix
Conversation
Contributor
Author
|
@yeya24 Can you see please see if this is alright? |
yeya24
approved these changes
Sep 17, 2020
Contributor
yeya24
left a comment
yeya24
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution!
yeya24
reviewed
Sep 17, 2020
squat
approved these changes
Sep 18, 2020
Member
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
lgtm :)
Can you rebase? Then we can merge
kakkoyun
reviewed
Sep 18, 2020
Signed-off-by: Daksh Sagar <daksh.sagar@yahoo.com>
Signed-off-by: Daksh Sagar <daksh.sagar@yahoo.com>
Member
|
For the future, changelog item is too code specific, we need to make sure it's understandable for a user e.g: I fixed it here, so this is just for learning purposes (: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daksh Sagar daksh.sagar@yahoo.com
Fix web.prefix-header to use
&wc.prefixHeaderNameinstead of&wc.externalPrefixFixes #3156
Changes
cmd/thanos/config.goinregisterFlagmethod, make cmd.Flag("web.prefix-header", "...", "...") use theprefixHeaderNamefield instead ofexternalPrefixVerification