ui: Fix assets not loading when --web.prefix-header is used#3234
Merged
squat merged 2 commits intothanos-io:masterfrom Sep 26, 2020
Merged
ui: Fix assets not loading when --web.prefix-header is used#3234squat merged 2 commits intothanos-io:masterfrom
--web.prefix-header is used#3234squat merged 2 commits intothanos-io:masterfrom
Conversation
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
onprem
changed the title
--web.prefix-header is used
Signed-off-by: Prem Kumar <prmsrswt@gmail.com>
onprem
force-pushed
the
fix-prefix-header
branch
from
f96532a to
da7e11b
Compare
squat
approved these changes
Sep 26, 2020
Contributor
|
I verified this fix is working. @prmsrswt @bwplotka Can we release this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--web.prefix-headerto set external prefix. Fixes [Query] UI served behind reverse proxy on a subpath broken on 0.15.0 #3226This was caused by incorrect handling of the prefix value we got from the header. If the header had
/as a suffix, we were still adding another/as a suffix to it, resulting in//prefixwhich translates to an external network request.Verification
Tested it using a reverse proxy with prefix-stripping and the header
X-Forwarded-Prefixset.