create download button to download metadata in blocks#3259
create download button to download metadata in blocks#3259squat merged 15 commits intothanos-io:masterfrom
Conversation
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
OGKevin
left a comment
OGKevin
left a comment
There was a problem hiding this comment.
Minor changes to the CHANGELOG.MD
CHANGELOG.md
Outdated
| - Bucket commands. | ||
| - Downsampling support for UI. | ||
| - Grafana dashboards for Thanos components. | ||
| - [#3259](https://github.com/thanos-io/thanos/pull/3259) Thanos BlockViewer. |
There was a problem hiding this comment.
Could you be a little more descriptive for the end user on what this PR adds? You can take inspiration from the PR title.
There was a problem hiding this comment.
Also this needs to be added at the top of the file under the "Unreleased" block.
There was a problem hiding this comment.
Thank you, I made the corrections
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
|
@prmsrswt I need help with the markdown link check? I do not understand why it is failing |
|
@Oghenebrume50 Sorry, please ignore this error first. I opened a pr to fix it in #3282. |
Hi thank you, there seems to be other test failing now though, and I do not think they are related to the markdown links, I also have no idea how to fix them. |
|
Everything works fine now once I merged the new changes from master into the branch, I also updated the screenshot of how the json file looks when viewed. @prmsrswt @yeya24 |
onprem
left a comment
onprem
left a comment
There was a problem hiding this comment.
Just some small nits, LGTM after this.
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
* create download button for download metadata file in blocks Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com> * add URL.createObjectURl to global jest config Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com> * adding changelog for this PR Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com> * adding changelog for this PR Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com> * fixing react linting issue Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com> * fix file not downloading but probable broke the linter Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com> * updated the changelog content and made it more descriptive Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com> * fix the issue with the jest not recognizing url createObject Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com> * modify code corrected typo and used reactstrap Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com> * fix linting issue Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com> * update page based on review given Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com> * add full stop at the end of changelog sentence Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
5 participants
Fixes #3222
Changes
Blockdetailscomponent to act as a download buttonVerification
The below screenshots show how it works
See download button and click on it
Receive the prompt to download file
view file after downloading