Segment files#3261
Merged
pracucci merged 9 commits intothanos-io:masterfrom Oct 2, 2020
pstibrany:segment-files
Merged
Conversation
Filled by components that write meta.json (shipper, compactor, repair, ...) Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Don't panic if segment index is incorrect. Added comment to Iter about sorted results. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
…lling block.GetSegmentFiles creates an import cycle. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
bwplotka
approved these changes
Sep 30, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Dear Peter.
Amazing. LGTM. 💪
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Contributor
Author
|
Dear Bartek, thanks for your review. I've updated the PR with your suggestions. Please take a look at your convenience. With love, |
pracucci
approved these changes
Oct 2, 2020
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
I double checked if the new property is set in every place and I think so. This is apparently a small optimisation, but according to our calculations it would have a big impact to reduce bucket listing operations. Thanks @pstibrany !
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds
segment_filesfield intometa.jsonfile (Thanos section), which lists all segment files for a block. This helps to avoid call to storage to get this list. This small optimization helps to reduce amount of LIST operations in clusters with many created blocks.Verification
store/bucket.gois hit by existing tests.