Fix Rule UI /rules endpoint bug#3346
Merged
kakkoyun merged 1 commit intothanos-io:masterfrom Oct 21, 2020
sevagh:fix-ui-bug
Merged
Fix Rule UI /rules endpoint bug#3346kakkoyun merged 1 commit intothanos-io:masterfrom sevagh:fix-ui-bug
kakkoyun merged 1 commit intothanos-io:masterfrom
sevagh:fix-ui-bug
Conversation
Signed-off-by: Sevag Hanssian <sevagh@protonmail.com>
kakkoyun
approved these changes
Oct 21, 2020
Member
kakkoyun
left a comment
kakkoyun
left a comment
There was a problem hiding this comment.
🥇 LGTM. Good catch. Thanks for your contribution.
@allenmqcymp @prmsrswt Anything thing else you want to add before we merge this?
onprem
approved these changes
Oct 21, 2020
Member
onprem
left a comment
onprem
left a comment
There was a problem hiding this comment.
Looks fine to me. Thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sevag Hanssian sevagh@protonmail.com
Changes
This applies a similar change as the Prometheus project: prometheus/prometheus#7865
Verification
This fixes #3311 - in my existing Thanos setup, without this PR the rule UI (/rules page) doesn't show the rules correctly. I have this change deployed in production currently, working fine.