Query Frontend: Set CORS header#3414
Merged
bwplotka merged 1 commit intothanos-io:masterfrom Nov 6, 2020
Merged
Conversation
6029089 to
d98777c
Compare
Member
|
Does this also work when you use POST? Because we have: var corsHeaders = map[string]string{
"Access-Control-Allow-Headers": "Accept, Accept-Encoding, Authorization, Content-Type, Origin",
"Access-Control-Allow-Methods": "GET, OPTIONS",
"Access-Control-Allow-Origin": "*",
"Access-Control-Expose-Headers": "Date",
} |
Contributor
Author
@GiedriusS that's an interesting question. I wonder how it works right now with Querier. I am looking into this. |
Contributor
Author
|
Even now (thanos 0.16), POST is not allowed from what I see 🤔 |
3a4fbba to
3e4ac53
Compare
Contributor
Author
|
|
Set CORS to the query frontend component in order to be able to freely access it from Grafana's living elsewhere. This is similar to what already happens for the Query component. Signed-off-by: Markos Chandras <markos@chandras.me>
3e4ac53 to
959c300
Compare
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
Set CORS to the query frontend component in order to be able to freely access it from Grafana's living elsewhere. This is similar to what already happens for the Query component. Signed-off-by: Markos Chandras <markos@chandras.me> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set CORS to the query frontend component in order to be able
to freely access it from Grafana's living elsewhere.
Signed-off-by: Markos Chandras markos@chandras.me
Changes
Set
Access-Control-Allow-OriginHeader to Query FrontendVerification
make test-e2e-local