queryFrontend: only set query url to localhost if config option is falsy #6524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `THANOS_QUERY_URL` constant is already assigned to `{{ .queryURL }}` in `public/index.html`.
Remove this comparison, as it causes the `--alert.query-url` command line option to have no effect whatsoever.
Fixes thanos-io#6370
Signed-off-by: Steffen Neubauer <[email protected]>
stefreak
changed the title
Member
|
Maybe you could add a test for this using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
THANOS_QUERY_URLconstant is already assigned to{{ .queryURL }}inpublic/index.html. Remove this comparison, as it causes the--alert.query-urlcommand line option to have no effect whatsoever.Fixes #6370
Verification