sidecar initially becomes ready only after underlying prometheus is r… #6587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eady to run queries Signed-off-by: Alexander Tunik <[email protected]>
GiedriusS
approved these changes
Aug 7, 2023
GiedriusS
reviewed
Aug 7, 2023
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
Maybe we could add a test that just starts Sidecar and checks that it is not ready? Also, please rebase on newest main which contains a fix for CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removing needless sidecar readiness on grpc-server binding