Track failed connections to strict endpoints #6621
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EndpointSet will ignore strict endpoints if it fails to connect to them. This can lead to queries not reporting partial response if one or more such endpoints are not available when the querier starts. This commit modifies the EndpointSet to track failed connections separately from endpoint refs. If one or more connect failures are present at query time, we inject a store client that will always return an error. This way the query will either fail, or return a warning when partial response is enabled. Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Filip Petkovski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EndpointSet will ignore strict endpoints if it fails to connect to them. This can lead to queries not reporting partial response if one or more such endpoints are not available when the querier starts.
This commit modifies the EndpointSet to track failed connections separately from endpoint refs. If one or more connect failures are present at query time, we inject a store client that will always return an error. This way the query will either fail, or return a warning when partial response is enabled.
Changes
Verification