"rule" Add CheckRulesFiles method to replace rulefmt.ParseFile in prometheus #6658
Conversation
cruvie
changed the title
cruvie
changed the title
pkg/rules/rules.go
Outdated
|
|
||
| import ( | ||
| "context" | ||
| "github.com/thanos-io/thanos/pkg/errutil" |
There was a problem hiding this comment.
can you group this with the other thanos-io imports?
There was a problem hiding this comment.
do you mean
import (
"github.com/thanos-io/thanos/pkg/errutil"
)There was a problem hiding this comment.
Ah, no i meant to put it on line 20 roughly where rules/rulespb and tracing are imported
| return srv.ctx | ||
| } | ||
|
|
||
| func CheckRulesFiles(filePaths []string) error { |
There was a problem hiding this comment.
I dont see that this is called anywhere; why is it needed?
There was a problem hiding this comment.
just like the issue I mentioned above, we need a method to replace rulefmt.ParseFile in prometheus since thanos change the alert rule file and and rulefmt.ParseFile cannot chech the changed file.
There was a problem hiding this comment.
Is there any way we could use it in the code-base itself? I'm afraid that this logic will get stale.
There was a problem hiding this comment.
no, the key func is ValidateAndCount(), which is used by thanos CLI tool,too.
Signed-off-by: Cruvie <>
3 participants
Changes
Add CheckRulesFiles method to replace rulefmt.ParseFile in prometheus
#6641
Verification
run TestCheckRulesFiles to text the method