Merged
Conversation
The in-process client uses a pull based iterator which needs to be closed, otherwise it will leak the underlying coroutine. When this happens, the tsdb reader will remain open which blocks head compaction indefinitely. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
fix-iter-leak
branch
from
ce047e7 to
5ed48cb
Compare
pedro-stanaka
approved these changes
Oct 14, 2024
Contributor
pedro-stanaka
left a comment
pedro-stanaka
left a comment
There was a problem hiding this comment.
LG - Let's add CHANGELOG? A bug fix, is a bug fix 🙂
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
fix-iter-leak
branch
from
d3b98d1 to
3dbc77f
Compare
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Contributor
Author
|
Added a changelog entry and some better tests to catch leaks. |
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
MichaHoffmann
previously approved these changes
Oct 14, 2024
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
MichaHoffmann
approved these changes
Oct 15, 2024
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
* Fix coroutine leak The in-process client uses a pull based iterator which needs to be closed, otherwise it will leak the underlying coroutine. When this happens, the tsdb reader will remain open which blocks head compaction indefinitely. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Fix race condition Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Fix CHANGELOG Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Improve tests Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Fix blockSeriesClient Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Fix unit test Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Fix another unit test Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2 tasks
This was referenced Apr 20, 2025
This was referenced Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in-process client uses a pull based iterator which needs to be closed, otherwise it will leak the underlying coroutine. When this happens, the tsdb reader will remain open which blocks head compaction indefinitely.
Changes
Verification