[tools] add flag for uploading compacted blocks to bucket upload-blocks#8359
Merged
yeya24 merged 3 commits intothanos-io:mainfrom Jul 24, 2025
Merged
Conversation
yeya24
previously approved these changes
Jul 7, 2025
Contributor
yeya24
left a comment
There was a problem hiding this comment.
Thanks. This change makes sense to me
Signed-off-by: James Geisler <geislerjamesd@gmail.com>
Signed-off-by: James Geisler <geislerjamesd@gmail.com>
Signed-off-by: James Geisler <geislerjamesd@gmail.com>
d8950b1 to
b13e308
Compare
yeya24
approved these changes
Jul 24, 2025
Contributor
yeya24
left a comment
There was a problem hiding this comment.
Thanks. Docs failure unrelated. Merging now
Naman-B-Parlecha
pushed a commit
to Naman-B-Parlecha/thanos
that referenced
this pull request
Jul 29, 2025
…ks (thanos-io#8359) * add flag for uploading compacted blocks to thanos tools Signed-off-by: James Geisler <geislerjamesd@gmail.com> * update changelog Signed-off-by: James Geisler <geislerjamesd@gmail.com> * fix doc check Signed-off-by: James Geisler <geislerjamesd@gmail.com> --------- Signed-off-by: James Geisler <geislerjamesd@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #8358
This is adding the flag
shipper.upload-compactedto enable uploading compacted blocks using thanos tools. This is the same approach used for the thanos-sidecar already.This flag is then used for
upload-blocksin theshipperto setshipper.WithUploadCompacted.Verification
I have successfully tested this locally.
Logs without the flag set. We can see the compacted blocks are skipped over.
Logs with the flag set. The compacted blocks are now uploaded.