block/compact: rework consistency check, make writers only write#8401
Merged
block/compact: rework consistency check, make writers only write#8401
Conversation
6666f78 to
e06bf51
Compare
e06bf51 to
18c9974
Compare
- It's weird that on upload errors, we try to clean everything and only then write again. It's an extra operation we don't need since whether a block exists or not hinges on the existence of meta.json. We don't need to delete old, same files before trying to upload them again. - Consequently, we need to always use the _upload_ time, not block creation time when checking for consistency or when deleting partially uploaded blocks. Directories as such don't exist in object storages, it's a client-side "illusion", so we need to iterate through the partial block's directory to fetch the last modified date. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
18c9974 to
d42ecb5
Compare
MichaHoffmann
previously approved these changes
Jul 30, 2025
c1f53c4 to
b72f4da
Compare
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
b72f4da to
57031c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on old #2883, #2585