block: assume that we do not unmark a block for deletion#8464
Merged
Conversation
GiedriusS
force-pushed
the
assume_unmark_upstream
branch
from
d243dd2 to
3d2baf0
Compare
GiedriusS
force-pushed
the
assume_unmark_upstream
branch
2 times, most recently
from
6bb6f70 to
c7411f5
Compare
Just like we assume that the meta.json file doesn't change, let's also assume that we do not unmark a block for deletion. This solves a critical issue in Thanos Store where there is a race between deletion in compactor and the loading of a block: - Deletion starts from meta.json, deletion marker are deleted at the end - Store sees that block, loads it by using the local in-memory and disk cache - By the time the deletion marker filtering functions is executed, the marker is deleted by Compactor - Store happily tries to load that block The root cause is that we are doing listing & checking markers in two or more separate steps. Since that is inevitable, we need to assume that the marker won't disappear until the block is there. This is the case when everything is working normally. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
assume_unmark_upstream
branch
from
c7411f5 to
6e231d0
Compare
adezxc
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like we assume that the meta.json file doesn't change, let's also assume that we do not unmark a block for deletion.
This solves a critical issue in Thanos Store where there is a race between deletion in compactor and the loading of a block:
The root cause is that we are doing listing & checking markers in two or more separate steps. Since that is inevitable, we need to assume that the marker won't disappear until the block is there. This is the case when everything is working normally.