Rule component: Adding new API end point for rules and alerts in #851
Merged
bwplotka merged 6 commits intothanos-io:masterfrom Mar 4, 2019
Merged
Rule component: Adding new API end point for rules and alerts in #851bwplotka merged 6 commits intothanos-io:masterfrom
bwplotka merged 6 commits intothanos-io:masterfrom
Conversation
bwplotka
approved these changes
Mar 4, 2019
Member
bwplotka
left a comment
There was a problem hiding this comment.
I think we could put it in single v1 package for ease of use... But that's fine for now, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding 2 new API end points for the rule component :
Changes
Its also an option to add a common class for shared code of rule and query components, but I wasn't sure this is necessary.
Verification