feat: add gomemlimits debug logs for the amount of reserved memory#8556
Merged
fpetkovski merged 2 commits intothanos-io:mainfrom Dec 24, 2025
Merged
Conversation
TessaIO
force-pushed
the
feat-add-gomemlimit-logs-indication
branch
from
7db4141 to
c216c6e
Compare
Contributor
Author
|
@saswatamcode @GiedriusS can we get this to be merged please? |
fpetkovski
reviewed
Dec 24, 2025
Contributor
fpetkovski
left a comment
fpetkovski
left a comment
There was a problem hiding this comment.
@TessaIO the docs CI failure seems legit. Let's get it resolved and I will merge this.
Signed-off-by: ahmed.g <ahmed.g@adjoe.io> Signed-off-by: TessaIO <ahmedgrati1999@gmail.com>
TessaIO
force-pushed
the
feat-add-gomemlimit-logs-indication
branch
from
19c2d3c to
e166fd3
Compare
Contributor
Author
|
@fpetkovski thanks for the review. The comment is addressed now. For the doc's failure, I can fix it in another PR. |
fpetkovski
approved these changes
Dec 24, 2025
Contributor
fpetkovski
left a comment
fpetkovski
left a comment
There was a problem hiding this comment.
My bad, seems unrelated to this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #8483
This PR adds useful debug logs when enabling GOMEMLIMIT, which logs the effective memory limit on startup for all thanos components.
Verification
Local run: