Query-Frontend: Fix not logging requests when external-prefix is set#8558
Merged
saswatamcode merged 1 commit intothanos-io:mainfrom Nov 26, 2025
Merged
Conversation
vCra
force-pushed
the
feature/query-frontend-slowlog-prefix
branch
2 times, most recently
from
993c2b6 to
62c1dd8
Compare
pedro-stanaka
approved these changes
Nov 14, 2025
vCra
force-pushed
the
feature/query-frontend-slowlog-prefix
branch
3 times, most recently
from
ecd1ced to
3a9a04c
Compare
Signed-off-by: Aaron Walker <aaron@vcra.io>
vCra
force-pushed
the
feature/query-frontend-slowlog-prefix
branch
from
3a9a04c to
e0e043c
Compare
saswatamcode
approved these changes
Nov 26, 2025
coleenquadros
pushed a commit
to coleenquadros/thanos
that referenced
this pull request
Jan 12, 2026
…hanos-io#8558) Signed-off-by: Aaron Walker <aaron@vcra.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updated Query-Frontend so that slowlogs still work if query has
--web.external-prefix=setPreviously we only logged if query didn't have any prefix
Verification
Added a test with the new path