Support newly added --storage.tsdb.delay-compact-file.path Prometheus…#8582
Merged
GiedriusS merged 2 commits intothanos-io:mainfrom Dec 9, 2025
Merged
Conversation
MichaHoffmann
previously approved these changes
Dec 2, 2025
Member
|
Closes #206? 🚀 |
… flag Prometheus has a new flag --storage.tsdb.delay-compact-file.path - prometheus/prometheus#17435. When this flag is passed Prometheus will check which blocks are marked as uploaded in external file and only compact these. Thanos should look for this flag and if it's set then it can stop forcing people to disable compactions. Signed-off-by: Lukasz Mierzwa <lukasz@cloudflare.com>
Signed-off-by: Lukasz Mierzwa <lukasz@cloudflare.com>
prymitive
dismissed stale reviews from saswatamcode and MichaHoffmann
via
3a0665e
prymitive
force-pushed
the
storage.tsdb.delay-compact-file.path
branch
from
c889563 to
3a0665e
Compare
GiedriusS
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… flag
Prometheus has a new flag --storage.tsdb.delay-compact-file.path - prometheus/prometheus#17435. When this flag is passed Prometheus will check which blocks are marked as uploaded in external file and only compact these. Thanos should look for this flag and if it's set then it can stop forcing people to disable compactions.
Changes
Verification