Tools: add --shipper.upload-compacted flag for controlling upload con…#8595
Merged
saswatamcode merged 1 commit intothanos-io:mainfrom Jan 22, 2026
Merged
Tools: add --shipper.upload-compacted flag for controlling upload con…#8595saswatamcode merged 1 commit intothanos-io:mainfrom
saswatamcode merged 1 commit intothanos-io:mainfrom
Conversation
saswatamcode
previously approved these changes
Dec 10, 2025
Member
saswatamcode
left a comment
saswatamcode
left a comment
There was a problem hiding this comment.
Generally LGTM, just one comment
| } | ||
|
|
||
| // WithUploadConcurrency sets the number of goroutines to use when uploading block files. | ||
| func WithUploadConcurrency(concurrency int) Option { |
Member
There was a problem hiding this comment.
Given this adds a new shipper option, maybe we should add this flag to all components that use shipper, like rule and receive as well?
Contributor
Author
There was a problem hiding this comment.
I didn't at first, because I didn't know if this is safe in the context of components which run as services, possibly concurrently with other components that modify data. (I assumed bucket tool is an admin tool and executed when the components are generally offline).
On second thought I can add the flag but default to 0 (including the bucket tool) so as to avoid surprising people. WDYT?
Contributor
Author
There was a problem hiding this comment.
Added the commit, PTAL
dowgird
force-pushed
the
main
branch
4 times, most recently
from
70fe059 to
8349902
Compare
yeya24
reviewed
Jan 5, 2026
yeya24
approved these changes
Jan 15, 2026
Signed-off-by: Rafał Dowgird <rafal.dowgird@rtbhouse.com>
coleenquadros
pushed a commit
to coleenquadros/thanos
that referenced
this pull request
Mar 9, 2026
thanos-io#8595) Signed-off-by: Rafał Dowgird <rafal.dowgird@rtbhouse.com> Co-authored-by: Rafał Dowgird <rafal.dowgird@rtbhouse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…currency in bucket upload-blocks
Changes
Verification