objstore: do not set last successful time metric before 1st upload#921
Merged
bwplotka merged 1 commit intothanos-io:masterfrom Mar 14, 2019
Merged
objstore: do not set last successful time metric before 1st upload#921bwplotka merged 1 commit intothanos-io:masterfrom
bwplotka merged 1 commit intothanos-io:masterfrom
Conversation
Convert lastSuccessfullUploadTime into a GaugeVec with one dimension: bucket, which makes client_golang *not* make that metric unless at least one value has appeared. This is better for users since Grafana will show that last upload has been 49+ years ago instead of N/A when no uploads had happened before. Fixes thanos-io#886.
bwplotka
approved these changes
Mar 14, 2019
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Wow, that's tiny detail, but I get that pain (: LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert lastSuccessfullUploadTime into a GaugeVec with one dimension:
bucket, which makes client_golang not make that metric unless at least
one value has appeared.
This is better for users since Grafana will show that last upload has
been 49+ years ago instead of N/A when no uploads had happened before.
Fixes #886.