sidecar: Handle intermediate restarts of sidecar gracefully.#941
Merged
sidecar: Handle intermediate restarts of sidecar gracefully.#941
Conversation
bwplotka
changed the title
bwplotka
force-pushed
the
934-shipper-upload-failure
branch
from
d331f08 to
1b03bc8
Compare
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
934-shipper-upload-failure
branch
from
1b03bc8 to
e85ca0e
Compare
Member
Author
|
Can you try this out @SuperQ ? |
SuperQ
approved these changes
Mar 19, 2019
Contributor
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
LGTM.
This anonymous function is getting quite long. I would recommend to refactor things to eliminate the anonymous function that seems to be there simply to get around variable scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #934
CC @SuperQ
Signed-off-by: Bartek Plotka bwplotka@gmail.com