config: Add possibility to inline ServiceAccount into GCS config#963
Merged
bwplotka merged 3 commits intothanos-io:masterfrom Mar 26, 2019
Merged
config: Add possibility to inline ServiceAccount into GCS config#963bwplotka merged 3 commits intothanos-io:masterfrom
bwplotka merged 3 commits intothanos-io:masterfrom
Conversation
bwplotka
approved these changes
Mar 23, 2019
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Thanks! LGTM, with suggesitons.
| opts = append(opts, option.WithCredentials(credentials)) | ||
| } | ||
|
|
||
| opts = append(opts, |
Member
There was a problem hiding this comment.
As a side thing (not a blocker for this PR), can we unsure, "debug" name from debug.name flag is passed here? for component for example? It would help if use agent would be actually some name you configured I guess?
Co-Authored-By: metalmatze <mail@matthiasloibl.com>
povilasv
approved these changes
Mar 26, 2019
metalmatze
force-pushed
the
gcs-serviceaccount-config
branch
from
e44cdb8 to
76f47f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
service_accountas multi line string to GCS config.Verification
I've tested that the binary locally starts without any connections errors.
We need this change so that we can have one unified way of configuring the Thanos object storage. Additionally it will make the Prometheus Operator's life easier to manage those components (sidecar).
/cc @bwplotka @brancz @s-urbaniak