Bucket: verify sort metas by MinTime before overlap check#966
Merged
GiedriusS merged 1 commit intothanos-io:masterfrom Mar 23, 2019
Merged
Bucket: verify sort metas by MinTime before overlap check#966GiedriusS merged 1 commit intothanos-io:masterfrom
GiedriusS merged 1 commit intothanos-io:masterfrom
Conversation
mreichardt95
force-pushed
the
bucket_sort_metas
branch
from
e814dfa to
f03bb13
Compare
GiedriusS
approved these changes
Mar 23, 2019
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
LGTM, the magic happens here: https://github.com/prometheus/tsdb/blob/master/db.go#L553
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #908
Changes
According to https://github.com/prometheus/tsdb/blob/master/db.go#L778
OverlappingBlocks()requires a sorted Slice by MinTime.Verification
Verify no longer shows overlapping blocks, that overlap by
0s.make testpasses