Fixes #21737 - move about page to react #5024
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| module AboutHelper | ||
| def plugins | ||
| @plugins.map do |plugin| | ||
| {:name => {name: plugin.name, url: plugin.url}, :description => plugin.description, | ||
| :author => plugin.author, :version => plugin.version } | ||
| end | ||
| end | ||
|
|
||
| def proxies | ||
| @smart_proxies.map do |proxy| | ||
| {:id => {:name => proxy.name, :id => proxy.id}, | ||
| :features => proxy.features.map(&:name).to_sentence} | ||
| end | ||
| end | ||
|
|
||
| def providers | ||
| nil unless SETTINGS[:unattended] | ||
| @providers.map do |provider| | ||
| {:provider => provider[:friendly_name], | ||
| :status => provider[:status] == :installed} | ||
| end | ||
| end | ||
|
|
||
| def compute_resources | ||
| nil unless SETTINGS[:unattended] | ||
| @compute_resources.map do |compute| | ||
| {:id => {:name => compute.name, :id => compute.id}, | ||
| :type => compute.provider_friendly_name} | ||
| end | ||
| end | ||
|
|
||
| def about_data | ||
| {:compute => compute_resources, :proxy => proxies, :plugin => plugins, :provider => providers } | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| export const computeResource = () => ({ | ||
| header: __('Compute Resource'), | ||
| description: __('Foreman supports creating and managing hosts on a number of virtualization and cloud services - referred to as “compute resources” - as well as bare metal hosts.'), | ||
| documentation: { | ||
| // eslint-disable-next-line no-undef | ||
| url: `https://www.theforeman.org/manuals/${VERSION}/index.html#5.2ComputeResources`, | ||
|
Member
There was a problem hiding this comment. I found out that the docs link (and the other too) leads to 404. |
||
| }, | ||
| action: { | ||
| title: __('Create a compute resource'), | ||
| url: '/compute_resources/new', | ||
| }, | ||
| }); | ||
|
|
||
| export const plugin = () => ({ | ||
| header: __('Plugin'), | ||
| description: __('Plugins are tools to extend and modify the functionality of Foreman. Plugins offer custom functions and features so that each user can tailor their environment to their specific needs.'), | ||
| documentation: { | ||
| // eslint-disable-next-line no-undef | ||
| url: `https://www.theforeman.org/manuals/${VERSION}/index.html#Plugins`, | ||
| }, | ||
| action: { | ||
| title: __('Get a plugin'), | ||
| url: 'https://projects.theforeman.org/projects/foreman/wiki/List_of_Plugins', | ||
| }, | ||
| }); | ||
|
|
||
| export const smartProxy = () => ({ | ||
| header: __('Smart Proxy'), | ||
| description: __('The Smart Proxy provides an easy way to add or extended existing subsystems, via DHCP, DNS, Puppet, etc.'), | ||
| documentation: { | ||
| // eslint-disable-next-line no-undef | ||
| url: `https://www.theforeman.org/manuals/${VERSION}/index.html#Smart-Proxy`, | ||
| }, | ||
| action: { | ||
| title: __('Create a smart proxy'), | ||
| url: '/smart_proxies/new', | ||
| }, | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you are creating a controller per action, then I would expect AboutPluginController with only index action.
having said that, I would default to use the API first and only if it doesnt fit create a UI end point
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created About controller namespace, inspired by this post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in that case why do you need the helper than?
also.. can't we simply use the existing api?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using an api endpoint would definitely be more systemic. Such endpoint doesn't exist at the moment. We can only list proxies and compute profiles separately. How about moving it to a new api endpoint? It would help with http://projects.theforeman.org/issues/3036.
But I understand it's adds some work and there are probably issues with higher priority. So if you don't have space for moving it to API, I can live with the current state ;)