Support camelCase fields (via a json_names option).#142
Merged
thesayyn merged 5 commits intothesayyn:mainfrom Jun 4, 2022
Merged
Support camelCase fields (via a json_names option).#142thesayyn merged 5 commits intothesayyn:mainfrom
thesayyn merged 5 commits intothesayyn:mainfrom
Conversation
Author
|
I should mention, this has the benefit that if the proto author overrides the JSON name manually, that will be used. e.g.: message Msg {
string a_field = 1 [json_name = "customFieldName"];
}then the generated JS will use |
Owner
|
Hey. thanks for working on this. I will look into it sometime this week. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this has been asked for a lot, so I decided to implement it. It turns out
FieldDescriptorProtoalready has ajson_namefor each field, as generated by the protobuf compiler, so this option just causes the compiler to use that (instead offieldDescriptor.name) for all generated descriptors. Obviously I left in the default behavior of using the names from the proto definitions as-is, for backwards compatibility.Let me know if I need to add more tests; I wrote a simple smoke test that seems to work though.