Add XMLSerializer->appendToWriter() #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
this is good to go and a requirement for the php-code-coverage perf improvement in sebastianbergmann/php-code-coverage#1125 |
Contributor
Author
|
@theseer do you have a opinion on this one? :) |
staabm
commented
Nov 26, 2025
| return $writer->outputMemory(); | ||
| } | ||
|
|
||
| public function appendToWriter(XMLWriter $writer, TokenCollection $tokens): void { |
Contributor
Author
There was a problem hiding this comment.
extracted the inner parts of toXML into a new separate method.
toXML itself did not change from a caller point of view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo
With support to write into a consumer given XMLWriter tokinzer results can be consumed more efficiently, because there no longer is a DOM to XMLWriter conversion required.