engine compatibility #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thevishalagarwal
force-pushed
the
engine-compatibility
branch
from
51ef969 to
09b8efb
Compare
thevishalagarwal
force-pushed
the
engine-compatibility
branch
from
09b8efb to
348ff75
Compare
| if(node->OpType() == EPCONTEXT_OP) { | ||
| auto& attrs = node->GetAttributes(); | ||
| auto trt_engine = attrs.at(EP_CACHE_CONTEXT); | ||
| if(!trt::isValidEngine(trt_engine)) |
Owner
Author
There was a problem hiding this comment.
Can we call TRT API from here? How do we initialize TRT runtime?
Owner
Author
There was a problem hiding this comment.
onnxruntime/onnxruntime/core/providers/nv_tensorrt_rtx/nv_execution_provider.cc
Lines 1207 to 1208 in 396fd13
ankan-ban
reviewed
Jun 17, 2025
| * Recompile if not incompatible | ||
| */ | ||
| virtual common::StatusCode isValidCompiledModel(const onnxruntime::Graph& graph) { | ||
| return true; |
There was a problem hiding this comment.
you probably wanted to return MODEL_SUPPORTED_OPTIMAL here (or maybe MODEL_UNSUPPORTED)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pseudo code for compiled model compatibility