Fix documentation reference to nonexistant package#105
Merged
jayjb merged 1 commit intothinkst:masterfrom Dec 11, 2023
Merged
Conversation
Trying to install python-pip and python-dev on Ubuntu 20.04 results in "Package python-pip is not available", and "selecting 'python-dev-is-python2' instead of 'python-dev'" respectively. Adding the explicit python3 reference fixes the issue
jayjb
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've recently set up a self-hosted canarytokens instance, and the python packages being referenced in the installation instructions not existing on Ubuntu 20.04 was one of the things I stumbled over. (The other being that setting the CANARY_ALERT_EMAIL... fields is only implicitly mentioned).
This PR fixes the broken reference by explicitly requesting python3-pip and python3-dev, which exist, install without issue, and result in a functioning canarytokens instance.
To reproduce the issue simply run
sudo apt-get install python-pip python-devon any Ubuntu 20.04.