Merged
Conversation
|
|
||
| # copy the built frontend assets | ||
| RUN rm -rf /srv/dist | ||
| COPY --from=frontend-builder /build/dist /srv/dist |
There was a problem hiding this comment.
Just a quick doublecheck that this shouldn't perhaps be /build/frontend/dist ?
Contributor
Author
There was a problem hiding this comment.
The dist is indeed built in the parent directory of the frontend source (I'm not sure why)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Instead of building and committing the frontend dist to the repo, we can instead build the frontend dist as part of building the Docker image. We use a separate stage to ensure that the node tooling doesn't end up in the final image.
Types of changes
What types of changes does your code introduce to this repository?
Checklist
pre-commitin the repo)Testing
Built the Docker image locally specifying the
GITHUB_SHAbuild arg. Ran the frontend Python service in the container, loaded the frontend in a browser and did spot checks to see that the frontend was correctly built and working as expected. Also checked that the sameGITHUB_SHAwas shown at the bottom of the page as the build ID.