Skip to content

Conversation

@iketw
Copy link
Contributor

@iketw iketw commented Jul 10, 2023

  • Eliminate ThirdwebStorage empty creation in SDK
  • Create new getValidChainRPCs in the chains package
  • Pass clientId in react-core, react, react-native and unity-bridge
  • Pass clientId and secretKey in: wallets, sdk, storage
  • Delete all default api keys
  • Warn devs when not passing a clientId - they will get limited access to our services
  • Rename paper's clientId to paperClientId

@iketw iketw requested review from a team and jnsdls as code owners July 10, 2023 23:27
@iketw iketw requested a review from a team July 10, 2023 23:27
@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023

🦋 Changeset detected

Latest commit: b86eb14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@thirdweb-dev/sdk Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/storage Minor
@thirdweb-dev/chains Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/react-native-compat Patch
@thirdweb-dev/wallets Minor
thirdweb Minor
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iketw iketw changed the title Ike/key Passes apiKey in all packages. Deprecates thirdwebApiKey Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 75.92% and project coverage change: -0.03 ⚠️

Comparison is base (dac8fa7) 70.67% compared to head (b86eb14) 70.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1316      +/-   ##
==========================================
- Coverage   70.67%   70.65%   -0.03%     
==========================================
  Files         316      317       +1     
  Lines       11122    11128       +6     
  Branches     1447     1451       +4     
==========================================
+ Hits         7860     7862       +2     
- Misses       2656     2658       +2     
- Partials      606      608       +2     
Impacted Files Coverage Δ
packages/sdk/src/core/constants/urls.ts 0.00% <0.00%> (-50.00%) ⬇️
.../getEncodedConstructorParamsForThirdwebContract.ts 38.09% <ø> (-2.82%) ⬇️
...common/any-evm-utils/getThirdwebContractAddress.ts 40.00% <ø> (-5.46%) ⬇️
...on/any-evm-utils/predictThirdwebContractAddress.ts 33.33% <ø> (-3.04%) ⬇️
...k/src/evm/common/currency/approveErc20Allowance.ts 85.71% <ø> (ø)
...s/sdk/src/evm/common/currency/hasERC20Allowance.ts 100.00% <ø> (ø)
...s/sdk/src/evm/common/currency/setErc20Allowance.ts 87.50% <ø> (ø)
packages/sdk/src/evm/common/marketplace.ts 75.30% <ø> (ø)
...sdk/src/evm/common/plugin/getCompositePluginABI.ts 75.00% <ø> (ø)
...sdk/src/evm/common/plugin/getMetadataForPlugins.ts 89.18% <ø> (ø)
... and 47 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iketw
Copy link
Contributor Author

iketw commented Jul 11, 2023

@MananTank can your PR: #1319 on top of this one?

@iketw
Copy link
Contributor Author

iketw commented Jul 17, 2023

/release-pr

@iketw
Copy link
Contributor Author

iketw commented Jul 17, 2023

/release-pr

@iketw
Copy link
Contributor Author

iketw commented Jul 17, 2023

/release-pr

@jnsdls jnsdls enabled auto-merge July 17, 2023 23:47
@jnsdls jnsdls added this pull request to the merge queue Jul 17, 2023
Merged via the queue into main with commit d844714 Jul 17, 2023
@jnsdls jnsdls deleted the ike/key branch July 17, 2023 23:58
@github-actions github-actions bot mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants