Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
7524d7a
wip
ciaranightingale Jul 5, 2023
de65f04
merge main
ciaranightingale Jul 5, 2023
98c7018
wip
ciaranightingale Jul 12, 2023
820d4cc
Merge branch 'main' into ciara/tba
ciaranightingale Jul 12, 2023
4755ac0
merge main
ciaranightingale Jul 24, 2023
2580d13
wip
ciaranightingale Jul 24, 2023
279b260
update with clientId & secretKey & requested changes
ciaranightingale Jul 24, 2023
c8445b9
Merge branch 'ciara/tba' of https://github.com/thirdweb-dev/js into c…
ciaranightingale Jul 24, 2023
af57f47
Merge branch 'main' into ciara/tba
ciaranightingale Jul 24, 2023
2db5249
fix build
ciaranightingale Jul 24, 2023
73a51fa
wip
ciaranightingale Jul 26, 2023
39e22b9
wip
ciaranightingale Jul 26, 2023
f34654b
Merge branch 'ciara/tba' of https://github.com/thirdweb-dev/js into c…
ciaranightingale Jul 26, 2023
7477b73
restructure
Jul 26, 2023
5ab826b
cleanup
joaquim-verges Jul 27, 2023
909ca2f
Merge branch 'main' into ciara/tba
joaquim-verges Jul 27, 2023
0c9ada2
Merge branch 'main' into ciara/tba
ciaranightingale Jul 27, 2023
cf5bb93
working code & fix factoryAddress required
ciaranightingale Jul 27, 2023
fdee3f5
Merge branch 'main' into ciara/tba
joaquim-verges Aug 9, 2023
0bdddc0
Merge branch 'main' into ciara/tba
joaquim-verges Aug 9, 2023
f11c12a
Merge branch 'main' into ciara/tba
joaquim-verges Oct 13, 2023
e93da7f
fix types
joaquim-verges Oct 14, 2023
6b4642a
linting
joaquim-verges Oct 14, 2023
8a07db2
fix build
joaquim-verges Oct 14, 2023
a8464f6
Merge branch 'main' into ciara/tba
joaquim-verges Oct 24, 2023
4c8dd1c
require account impl for now
joaquim-verges Oct 24, 2023
c9616ed
changeset
joaquim-verges Oct 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merge main
  • Loading branch information
ciaranightingale committed Jul 5, 2023
commit de65f04fcb343f455b8cb7119633eddbf66e2564
7 changes: 4 additions & 3 deletions packages/sdk/src/evm/core/classes/account.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@ import { AddressOrEns } from "../../schema";
import { resolveAddress } from "../../common";
import { Signer } from "ethers";

export class SmartWallet<TContract extends IAccountCore>
implements DetectableFeature {
featureName = FEATURE_SMART_WALLET.name;
export class Account<TContract extends IAccountCore>
implements DetectableFeature
{
featureName = FEATURE_ACCOUNT.name;
private contractWrapper: ContractWrapper<IAccountCore>;

private emptyRole: string =
Expand Down
25 changes: 23 additions & 2 deletions packages/wallets/src/evm/connectors/smart-wallet/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,28 @@ export class SmartWalletConnector extends Connector<SmartWalletConnectionArgs> {
};
}

set factoryAddress(value: string) {
this.factoryAddress = value;
private async getChainSlug(
chainOrRpc: ChainOrRpcUrl,
provider: ethers.providers.Provider,
): Promise<string> {
if (typeof chainOrRpc === "object") {
return chainOrRpc.slug;
}
if (typeof chainOrRpc === "number") {
const chain = getChainByChainId(chainOrRpc);
return chain.slug;
}
if (typeof chainOrRpc === "string") {
if (chainOrRpc.startsWith("http") || chainOrRpc.startsWith("ws")) {
// if it's a url, try to get the chain id from the provider
const chainId = (await provider.getNetwork()).chainId;
const chain = getChainByChainId(chainId);
return chain.slug;
}
// otherwise its the network name
return chainOrRpc;
} else {
throw new Error(`Invalid network: ${chainOrRpc}`);
}
}
}
9 changes: 1 addition & 8 deletions packages/wallets/src/evm/wallets/smart-wallet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,7 @@ export class SmartWallet

this.enableConnectApp = options?.enableConnectApp || false;
this.#wcWallet = this.enableConnectApp
? options?.wcVersion === "v1"
? new WalletConnectV1Handler({
walletConnectWalletMetadata: options?.walletConnectWalletMetadata,
walletConenctV2ProjectId: options?.walletConenctV2ProjectId,
walletConnectV2RelayUrl: options?.walletConnectV2RelayUrl,
storage: options?.wcStorage || createLocalStorage("smart-wallet"),
})
: new WalletConnectV2Handler({
? new WalletConnectV2Handler({
walletConnectWalletMetadata: options?.walletConnectWalletMetadata,
walletConenctV2ProjectId: options?.walletConenctV2ProjectId,
walletConnectV2RelayUrl: options?.walletConnectV2RelayUrl,
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.