Skip to content

[React] useTotalCount now always returns unclaimed + claimed tokens #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nachoiacovino merged 1 commit into from
Aug 29, 2022
Merged

[React] useTotalCount now always returns unclaimed + claimed tokens #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
useTotalCount now always returns unclaimed + claimed tokens
  • Loading branch information
@nachoiacovino
nachoiacovino committed Aug 29, 2022
commit 7bd261f7259df1b78a6c3eaa901e04d1b90da4de
5 changes: 5 additions & 0 deletions .changeset/neat-plants-greet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@thirdweb-dev/react": patch
---

useTotalCount always returns unclaimed and claimed tokens
7 changes: 0 additions & 7 deletions packages/react/src/hooks/async/nft.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,13 +219,6 @@ export function useTotalCount(contract: RequiredParam<NFTContract>) {
cacheKeys.contract.nft.query.totalCount(contractAddress),
() => {
invariant(contract, "No Contract instance provided");
if (contract.featureName === "ERC721") {
invariant(
contract?.query?.totalCirculatingSupply,
"Contract instance does not support query.totalCirculatingSupply",
);
return contract.query.totalCirculatingSupply();
}
invariant(
contract.query?.totalCount,
"Contract instance does not support query.totalCount",
Expand Down