Skip to content

[SDK] Improve contract-roles methods #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kien-ngo merged 4 commits into from
Oct 23, 2023
Merged

[SDK] Improve contract-roles methods #1798

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63256db
Add changeset
kien-ngo Oct 18, 2023
e077687
Fix lint
kien-ngo Oct 18, 2023
886e933
Merge branch 'main' into kien/idkwhatever2
kien-ngo Oct 18, 2023
3fb8209
Merge branch 'main' into kien/idkwhatever2
kien-ngo Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint
  • Loading branch information
@kien-ngo
kien-ngo committed Oct 18, 2023
commit e077687fae1983e578b91a27e3ca64f591f4fbbd
2 changes: 1 addition & 1 deletion packages/sdk/src/evm/core/classes/contract-roles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export class ContractRoles<TContract extends IPermissions, TRole extends Role>
invariant(this.roles.length, "this contract has no support for roles");
const roles = {} as Record<TRole, string[]>;
const entries = Object.entries(this.roles);
(await Promise.all(entries.map(([str, role]) => this.get(role)))).forEach(
(await Promise.all(entries.map(([, role]) => this.get(role)))).forEach(
(item, index) => (roles[entries[index][1]] = item),
);
return roles;
Expand Down