Skip to content

[SDK] Perf improvements for erc-20 methods #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kien-ngo merged 13 commits into from
Oct 24, 2023
Merged

[SDK] Perf improvements for erc-20 methods #1814

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
00b8908
Improve erc-20 methods
kien-ngo Oct 20, 2023
68425fd
Add changeset
kien-ngo Oct 20, 2023
5ec9266
Revert test
kien-ngo Oct 20, 2023
1e87810
Merge branch 'main' of https://github.com/thirdweb-dev/js into kien/c…
kien-ngo Oct 20, 2023
a9f3ad1
Update
kien-ngo Oct 20, 2023
d769a6d
Update
kien-ngo Oct 20, 2023
bceb44c
Update
kien-ngo Oct 20, 2023
7d725fd
Merge branch 'main' of https://github.com/thirdweb-dev/js into kien/c…
kien-ngo Oct 20, 2023
838d2d6
Update var name
kien-ngo Oct 20, 2023
9bcaf2a
Fix erc-20-history
kien-ngo Oct 20, 2023
5bcc410
Merge branch 'main' into kien/chore-20
kien-ngo Oct 24, 2023
ef1fd36
Update
kien-ngo Oct 24, 2023
53298a3
Merge branch 'kien/chore-20' of https://github.com/thirdweb-dev/js in…
kien-ngo Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update
  • Loading branch information
@kien-ngo
kien-ngo committed Oct 24, 2023
commit ef1fd364ee83609b3327af1eda991bcfa673d395
2 changes: 1 addition & 1 deletion packages/sdk/src/evm/core/classes/erc-20-signature-mintable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export class Erc20SignatureMintable implements DetectableFeature {
FilledSignaturePayload20[],
] = await Promise.all([
this.contractWrapper.getChainID(),
this.contractWrapper.read("name", []), // ERC20Permit (EIP-712) spec differs from signature mint 721, 1155.
this.contractWrapper.read("name", []), // ERC20Permit (EIP-712) spec differs from signature mint 721, 1155.
Promise.all(
payloadsToSign.map((m) => Signature20PayloadInput.parseAsync(m)),
),
Expand Down